Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Remove chartEmbeddablesEnabled feature flag and unused code #173675

Merged
merged 57 commits into from
Apr 15, 2024
Merged

[SecuritySolution] Remove chartEmbeddablesEnabled feature flag and unused code #173675

merged 57 commits into from
Apr 15, 2024

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Dec 19, 2023 •
edited
Loading

Summary

#171287

chartEmbeddablesEnabled feature flag has been switched on, all the bar charts and area charts are rendered with Lens Embeddable. We can safely delete the unused code.

test environment: https://p.elstc.co/paste/z8H+ojQh#N61NgBCvUUhj+2OkSal7M+z88HcYyaOmPbDUPKmPMM-

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Dec 20, 2023
@angorayc angorayc changed the title rm unused code [SecuritySolution] Remove the unused code for histograms and charts Dec 20, 2023
@angorayc angorayc changed the title [SecuritySolution] Remove the unused code for histograms and charts [SecuritySolution] Remove chartEmbeddablesEnabled feature flag and unused code Jan 11, 2024
@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc angorayc requested a review from a team as a code owner April 8, 2024 13:02
@angorayc angorayc requested a review from vitaliidm April 8, 2024 13:02
vitaliidm
vitaliidm approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine area LGTM

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

1 similar comment
@angorayc
Copy link
Contributor Author

/ci

@angorayc angorayc enabled auto-merge (squash) April 14, 2024 19:31
@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 15, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5384 5323 -61

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 17.2MB 17.1MB -163.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 77.4KB 77.4KB -27.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 517 512 -5

Total ESLint disabled count

id before after diff
securitySolution 594 589 -5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit b845917 into elastic:main Apr 15, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliidm vitaliidm vitaliidm approved these changes

@christineweng christineweng christineweng approved these changes

@semd semd semd approved these changes

@MadameSheema MadameSheema MadameSheema approved these changes

@maximpn maximpn maximpn approved these changes

@hop-dev hop-dev hop-dev approved these changes

@machadoum machadoum Awaiting requested review from machadoum machadoum was automatically assigned from elastic/security-entity-analytics

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely needs_docs release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@angorayc @elasticmachine @kibana-ci @hop-dev @maximpn @MadameSheema @semd @christineweng @vitaliidm @kibanamachine